Skip to content

internet-latency-collector: remove packet size from RIPE Atlas measurements#3102

Merged
nikw9944 merged 1 commit intomainfrom
nikw9944/infra-655
Feb 26, 2026
Merged

internet-latency-collector: remove packet size from RIPE Atlas measurements#3102
nikw9944 merged 1 commit intomainfrom
nikw9944/infra-655

Conversation

@nikw9944
Copy link
Contributor

@nikw9944 nikw9944 commented Feb 25, 2026

Summary of Changes

  • Remove the Size field from MeasurementDefinition struct in client.go and the Size: 1280 assignment in collector.go
  • The slc anchor probe (7549) does not support packets larger than 102 bytes, but the collector was requesting 1280-byte RIPE Atlas measurements, causing all 30 slc-related circuits to fail silently
  • By omitting size from the JSON payload, RIPE Atlas uses its default packet size which all probes support

Testing Verification

  • Verified fix by running snapshot build in mainnet-beta

Copy link
Contributor

@thijsvanemmerik thijsvanemmerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikw9944 nikw9944 enabled auto-merge (squash) February 26, 2026 19:34
@nikw9944 nikw9944 disabled auto-merge February 26, 2026 21:37
@nikw9944 nikw9944 enabled auto-merge (squash) February 26, 2026 21:38
@nikw9944 nikw9944 force-pushed the nikw9944/infra-655 branch 2 times, most recently from 75d8770 to 2b66f22 Compare February 26, 2026 22:35
@nikw9944 nikw9944 merged commit 199490c into main Feb 26, 2026
30 checks passed
@nikw9944 nikw9944 deleted the nikw9944/infra-655 branch February 26, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants